Implement debug handler based on command resolution #3354
Conversation
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
vscode
Graphite App
vinistock
force-pushed
the
03-25-implement_debug_handler_based_on_command_resolution
branch
from
676e9a7 to
d9a4f4e
Compare
There was a problem hiding this comment.
To workaround the stdio limitation, I wonder if it makes sense for the test reporter to communicate with the extension through sockets 🤔
Like:
- Before running tests, the extension creates a socket and expose its path in a env var
- The test reporter picks up the env var and writes to that socket instead of stdio
- Extension reads the socket
- After the tests finished, clear the socket
|
That's a great idea. I created #3359 so that we can explore that in more detail. It will impact all of the communication with the explorer panel, so I will still ship this PR as is. I hope we can indeed use sockets or a TCP server to communicate results, because then the debugging experience will be fully complete. |
vinistock
deleted the
03-25-implement_debug_handler_based_on_command_resolution
branch
Motivation
Closes #3311
This PR implements a new handler for the debug profile based on the test command resolution mechanism we created.
Implementation
Which profile is triggering the execution of the test explorer is included as part of the request parameter. This allows us to share the logic all the way after resolving test commands.
After that, we need to launch the debugger with the given commands instead of running them in the background like we do for the run profile.
Note
We unfortunately cannot use our JSON reporters to update the explorer's UI in this case, because the debugger needs to use the stdio pipes to communicate with the editor. We can't try to create a JSON RPC connection with the underlying process as that breaks the debug adapter.
Automated Tests
Added a test.
Manual Tests